Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an invokelatest that may be required in 1.12 #231

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

Keno
Copy link
Contributor

@Keno Keno commented Nov 20, 2024

This test currently relies on implicit world age increments at top level. We're re-evaluating where these go because julia is currently inconsistent about it in the interpreter, compiler and inference. To make sure this test keeps working on 1.12, add an explicit world age increment. See JuliaLang/julia#56509.

This test currently relies on implicit world age increments at top
level. We're re-evaluating where these go because julia is currently
inconsistent about it in the interpreter, compiler and inference.
To make sure this test keeps working on 1.12, add an explicit
world age increment. See JuliaLang/julia#56509.
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (7ae6079) to head (ff0443d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files          12       12           
  Lines         835      835           
=======================================
  Hits          801      801           
  Misses         34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/runtests.jl Outdated Show resolved Hide resolved
@fingolfin
Copy link
Member

Thank you @Keno

@fingolfin fingolfin merged commit fc31545 into oscar-system:master Nov 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants